Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly import urllib3.poolmanager #79

Closed
wants to merge 2 commits into from
Closed

correctly import urllib3.poolmanager #79

wants to merge 2 commits into from

Conversation

ruleant
Copy link
Contributor

@ruleant ruleant commented Sep 25, 2015

Even with dependencies (requests == 2.7) correctly installed an error message appeared :

  File "/usr/local/lib/python2.7/dist-packages/keen/api.py", line 8, in <module>
    from requests.packages.urllib3.poolmanager import PoolManager
ImportError: No module named packages.urllib3.poolmanager

This solution was suggested in a similar bug report of another python project : omab/python-social-auth#617 (comment)

Even with dependencies (requests == 2.7) correctly installed an error message appeared :

```
  File "/usr/local/lib/python2.7/dist-packages/keen/api.py", line 8, in <module>
    from requests.packages.urllib3.poolmanager import PoolManager
ImportError: No module named packages.urllib3.poolmanager
```

This solution was suggested in a similar bug report of another python project : omab/python-social-auth#617 (comment)
@ruleant
Copy link
Contributor Author

ruleant commented Sep 25, 2015

After some digging, it seems that requests library has imported the urllib3 library into its code, instead of adding it as a dependency.
When the urllib3 library is installed as a dependency, the above mentioned ImportError occurs.
Not sure what the best solution is here?

  • rely on the urllib3 version shipped with requests
  • install urllib3 library as a dependency and rely on that
  • convince the requests library maintainer to use the urllib3 as a dependency

@stroud109
Copy link
Contributor

Hey Dieter, Any chance you could provide a bit more info about how you encountered the issue? I'd like to be able to reproduce the issue before moving forward, but haven't had any success yet :-\

@ruleant
Copy link
Contributor Author

ruleant commented Oct 1, 2015

Hi Stephanie,
Strangely enough, I can't reproduce it anymore, either. :? So I guess
something else than the urllib3 dependency caused the problem.
I'll let you know when I encounter it again.

Kind regards,

Dieter

@ruleant ruleant closed this Oct 1, 2015
@stroud109
Copy link
Contributor

Thanks, Dieter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants