Passkeys: Wrap response to PublicKeyCredential #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varjolintu
force-pushed
the
fix/passkeys_wrap_response_to_publickeycredential
branch
from
ce3bf51
to
cc6d9cd
Compare
droidmonkey
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps the response to a proper
PublicKeyCredentialobject. The object is passed as a normal object from the content script, and constructed at the injected script side. I had some strange problems when passingPublicKeyCredentialobject directly to the injected script, so this is the safest way to ensure compatibility.Also fixes showing an error when credential is excluded, which is quite a common case. Even if we just let the lifetime timer run out, user should have some indication why the passkey creation fails.
I tested this with almost every site I have working passkeys. These changes didn't improve the situation with some problematic sites, e.g. Microsoft.
Supports extension JSON changes with keepassxreboot/keepassxc#10615.
Fixes #2173.