Adjust to coding conventions for PR#10625

keepassxreboot · Apr 26, 2024 · 632a63d · 632a63d
1 parent fff6b52
commit 632a63d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 17 deletions.
diff --git a/src/gui/group/GroupView.cpp b/src/gui/group/GroupView.cpp
@@ -44,8 +44,8 @@ GroupView::GroupView(Database* db, QWidget* parent)
     // clang-format on
 
     new QShortcut(Qt::CTRL + Qt::Key_F10, this, SLOT(contextMenuShortcutPressed()), nullptr, Qt::WidgetShortcut);
-    new QShortcut(Qt::CTRL + Qt::SHIFT + Qt::Key_PageUp, this, SLOT(prevGroup()), nullptr, Qt::WindowShortcut);
-    new QShortcut(Qt::CTRL + Qt::SHIFT + Qt::Key_PageDown, this, SLOT(nextGroup()), nullptr, Qt::WindowShortcut);
+    new QShortcut(Qt::CTRL + Qt::SHIFT + Qt::Key_PageUp, this, SLOT(selectPreviousGroup()), nullptr, Qt::WindowShortcut);
+    new QShortcut(Qt::CTRL + Qt::SHIFT + Qt::Key_PageDown, this, SLOT(selectNextGroup()), nullptr, Qt::WindowShortcut);
 
     // keyboard shortcuts to sort children of a group
     auto shortcut = new QShortcut(Qt::CTRL + Qt::Key_Down, this);
@@ -62,24 +62,22 @@ GroupView::GroupView(Database* db, QWidget* parent)
     setDefaultDropAction(Qt::MoveAction);
 }
 
-void GroupView::prevGroup()
+void GroupView::selectPreviousGroup()
 {
-    auto prevIndex = indexAbove(currentIndex());
-    if (!prevIndex.isValid())
-        return;
-
-    Group* prevGroup = m_model->groupFromIndex(prevIndex);
-    setCurrentGroup(prevGroup);
+    auto previousIndex = indexAbove(currentIndex());
+    if (previousIndex.isValid()) {
+        Group* previousGroup = m_model->groupFromIndex(previousIndex);
+        setCurrentGroup(previousGroup);
+    }
 }
 
-void GroupView::nextGroup()
+void GroupView::selectNextGroup()
 {
     auto nextIndex = indexBelow(currentIndex());
-    if (!nextIndex.isValid())
-        return;
-
-    Group* nextGroup = m_model->groupFromIndex(nextIndex);
-    setCurrentGroup(nextGroup);
+    if (nextIndex.isValid()) {
+        Group* nextGroup = m_model->groupFromIndex(nextIndex);
+        setCurrentGroup(nextGroup);
+    }
 }
 
 void GroupView::contextMenuShortcutPressed()

diff --git a/src/gui/group/GroupView.h b/src/gui/group/GroupView.h
@@ -46,8 +46,8 @@ private slots:
     void syncExpandedState(const QModelIndex& parent, int start, int end);
     void modelReset();
     void contextMenuShortcutPressed();
-    void prevGroup();
-    void nextGroup();
+    void selectPreviousGroup();
+    void selectNextGroup();
 
 protected:
     void dragMoveEvent(QDragMoveEvent* event) override;