Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Prompt for a master password, despite having quick unlock via Touch ID after opening the lid #8945

Closed
KORraNpl opened this issue Dec 31, 2022 · 6 comments · Fixed by #10092

Comments

@KORraNpl
Copy link
Contributor

Overview

I have quick unlock enabled. Whenever I try to unlock my database after it has been locked due to closing the lid), there is a prompt for a master password. There is no button for quick unlock. After typing anything in the field (bad / good password), only then prompt to use the Touch ID and the db gets unlocked (given I use the right finger, so this part works fine).

Note: This seems to work as expected if I manually lock the db / put the machine to sleep / lock it.

Steps to Reproduce

  1. Unlock a db with quick unlock enabled.
  2. Close the lid (make sure in your settings that KeePassXC will lock the db in this case).
  3. Open the lid and try to unlock the db.

Expected Behavior

As the quick unlock is enabled, I can click "Unlock Database" button, use the Touch ID to have the db unlocked.

Actual Behavior

I get a prompt for a password, then (regardless the password is valid or not), I get a prompt for using Touch ID.
image1
image2
image3

Context

KeePassXC - Version 2.7.4
Revision: 63b2394

Qt 5.15.6
Debugging mode is disabled.

Operating system: macOS 12.6
CPU architecture: arm64
Kernel: darwin 21.6.0

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • SSH Agent
  • KeeShare
  • YubiKey
  • Quick Unlock

Cryptographic libraries:

  • Botan 2.19.2
@KORraNpl KORraNpl added the bug label Dec 31, 2022
@droidmonkey
Copy link
Member

That is extremely odd. So the only real defect here is that the expected quick unlock view is not shown, but quick unlock still works.

@KORraNpl
Copy link
Contributor Author

Yeah, I agree that it's very odd. Initially, I thought that it requires both password AND Touch ID to unlock a db, so I suspected that it might be a desired behaviour, but after realizing that any password works, I was sure it's a defect.

Anyway, if you need anything in terms of reproduction, please let me know. I love KeePassXC and recent addition of quick unlock feature is a great idea!

@mikes625
Copy link

I can confirm this issue on my intel macbook air, OS 13.1. No master password required, just hitting return brings up the quick unlock popup. Never noticed it because I normally lock the db manually before shutting the lid.

@joh-klein
Copy link

I have this issue as well – I cant unlock the database anymore with the master password without touch-id. This is rather annoying, since I have an issue with my skin right now, were touch-id only sometimes works :(

@b0n0r
Copy link

b0n0r commented May 9, 2023

have seen this behaviour at coworker's mac too:

  • unlock database while using the laptop without external monitor & keyboard, everything works
  • close the lid of the laptop
  • connect external monitor & power & bluetooth keyboard ("clamshell mode")
    and you end up stuck, unable to unlock the database since it asks for fingerprint but that sensor is in the closed laptop :)

you have to close the db tab in the app and reopen (and unlock with master pw) the db to be able to use it.

UPDATE: actually my scenario is more like #9034 / #9032 which was just fixed in the fresh release 2.7.5 👍 😎

@droidmonkey droidmonkey self-assigned this May 9, 2023
@droidmonkey droidmonkey added this to the v2.8.0 milestone May 9, 2023
@KORraNpl
Copy link
Contributor Author

I know that this issue is assigned to 2.8.0, but I noticed there were some changes in 2.7.6 related to Quick Unlock, so I retested the issue and it's still there. Just my QA habit ;)

phoerious added a commit that referenced this issue Feb 22, 2024
phoerious added a commit that referenced this issue Feb 22, 2024
phoerious added a commit that referenced this issue Feb 22, 2024
phoerious added a commit that referenced this issue Feb 22, 2024
phoerious added a commit that referenced this issue Feb 22, 2024
phoerious added a commit that referenced this issue Feb 22, 2024
phoerious added a commit that referenced this issue Mar 7, 2024
phoerious added a commit that referenced this issue Mar 7, 2024
phoerious added a commit that referenced this issue Mar 7, 2024
phoerious added a commit that referenced this issue Mar 7, 2024
phoerious added a commit that referenced this issue Mar 7, 2024
phoerious added a commit that referenced this issue Mar 8, 2024
droidmonkey pushed a commit that referenced this issue Mar 8, 2024
droidmonkey pushed a commit that referenced this issue Mar 8, 2024
droidmonkey added a commit that referenced this issue Mar 9, 2024
droidmonkey added a commit that referenced this issue Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants