Add a password discard confirmation #10994
Open
+37
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jookia
force-pushed
the
WIP_passwordconfirm
branch
from
99c1a66
to
91422eb
Compare
droidmonkey
force-pushed
the
WIP_passwordconfirm
branch
from
91422eb
to
26128dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a confirmation dialog on password generator close that confirms discarding the password. Fixes #10831 .
Screenshots
Testing strategy
Tests are currently broken: Something about MessageBox::setNextAnswer is blocking the closing of the database in the test. Once this is fixed (I need help with this please) I will write tests that check:
Type of change