Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected additional resolved urls in testIconDownloader #11099

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

AMurkin
Copy link
Contributor

@AMurkin AMurkin commented Jul 23, 2024

I got unexpected additional resolved urls in testIconDownloader. Actual numbers were greater than expected for some test cases.
Set Config::Security_IconDownloadFallback to false before the test.

Testing strategy

It gave me:

> ./build/tests/testicondownloader
...
Totals: 23 passed, 0 failed, 0 skipped, 0 blacklisted

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey
Copy link
Member

This has never been a problem before

@AMurkin
Copy link
Contributor Author

AMurkin commented Jul 24, 2024

I thought so. I'm certain this happens because I have keepassxc installed and their configuration affects tests. So it needs to have local configuration initialized somewhere in tests (but I don't know where). This been said, I still think my changes are useful.

@droidmonkey
Copy link
Member

A new config file is made for each test, do you have an environment variable set directing where the config file is?

@AMurkin
Copy link
Contributor Author

AMurkin commented Jul 24, 2024

No, I don't have environment variables related to keepass.
QFileInfo(config()->getFileName()).absolutePath() gives me ~/.config/keepassxc in TestIconDownloader::testIconDownloader().

@droidmonkey droidmonkey added this to the v2.7.10 milestone Aug 19, 2024
@droidmonkey droidmonkey merged commit 9b4e6b4 into keepassxreboot:develop Aug 22, 2024
11 checks passed
@AMurkin AMurkin deleted the fix-testIconDownloader branch August 22, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants