Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent user from leaving unlock window by hitting ESC (#11199) #11221

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

WinnetouL
Copy link

@WinnetouL WinnetouL commented Sep 1, 2024

Fixes #11199
The issue is about to improve user experience. In case the user is about to unlock the database and hits the escape key while the password field is on focus, the unlock window would close.
From the user point of view the window should not be closed at that point. With current changes the unlock window will
not be closed anymore when hitting the escape key and instead a popup will open and asks if the user really wants to cancel the unlock process.

Open question:
I think these changes reflect the initial discussed solution for this issue.
The current process is the same when hitting the escape key or clicking on the "Close" button. In my opinion the workflow
might be fine when hitting ESC, but I don't think a further popup after clicking on "Close" would be necessary. Should this be changed?

Anything else that should be changed?

Screenshots

screenshot_kp

Testing strategy

Are tests for this kind of contribution expected?

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey
Copy link
Member

droidmonkey commented Sep 1, 2024

  1. The question should not appear if the user clicks the close button
  2. The question text should use "close": Would you like to close this database?
  3. The question should NOT appear ever for the database unlock dialog

An alternative to the modal popup question is a warning message displayed: "Press ESC again to close this database"

@droidmonkey droidmonkey added the ux label Sep 1, 2024
@WinnetouL
Copy link
Author

WinnetouL commented Sep 2, 2024

I got the first two points, @droidmonkey
Can you further explain what is meant by your third point? Do you mean the position of the popup?
thanks

@droidmonkey
Copy link
Member

When DatabaseOpenDialog is used, do not ask if you want to close the database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hitting Escape in a database pw entry closes the database
2 participants