Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KeePass2 TOTP settings #11229

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Support KeePass2 TOTP settings #11229

merged 1 commit into from
Sep 4, 2024

Conversation

droidmonkey
Copy link
Member

Screenshots

image

Testing strategy

Added unit tests

Type of change

  • ✅ New feature (change that adds functionality)

* Fixes #7263
* Also improves handling of custom TOTP settings
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.00%. Comparing base (2f01604) to head (4c882df).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/core/Totp.cpp 91.30% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11229      +/-   ##
===========================================
+ Coverage    62.98%   63.00%   +0.02%     
===========================================
  Files          362      362              
  Lines        37766    37783      +17     
===========================================
+ Hits         23785    23803      +18     
+ Misses       13981    13980       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@droidmonkey droidmonkey merged commit c8fc25e into develop Sep 4, 2024
11 checks passed
@droidmonkey droidmonkey deleted the fix/keepass2-totp branch September 4, 2024 10:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support KeePass2 TOTP configuration settings
2 participants