Support key files with Auto Open feature

[metaphys]

Fixes #3495
Summary of changes:

• DatabaseWidget::processAutoOpen() looks for custom attribute KeyFile in
  the AutoOpen's entry that should contain the path to a keyfile in the same
  format as for the database file
• requestOpenDatabase and its call are updated to handle this extra parameter

• ✅ New feature (non-breaking change which adds functionality)

Testing strategy

auto opening db with or without keyfile works (only tested on linux)

Checklist:

• ✅ I have read the CONTRIBUTING document. [REQUIRED]
• ✅ My code follows the code style of this project. [REQUIRED]
• ✅ All new and existing tests passed. [REQUIRED]
• ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

[droidmonkey]

I think you are missing a lot of the changes you meant to include in this PR

[metaphys]

Yeah sorry I pushed that late yesterday, it's corrected now.

[metaphys]

I didn't find where are the docs to edit for auto open, could you point me to it?

[droidmonkey]

They are missing and need to be created. You are welcome to do that in this pr

[metaphys]

Well it seems that I still have trouble with that commit :/

[metaphys]

Ok that will do for indentation problems and wrongly removed section.
Where should I add the auto open doc? in docs/QUICKSTART.md?

[droidmonkey]

Yes that is good

[metaphys]

Ok this should be ready for pulling now. (You probably want to correct my awful #engrish before)

[phurrelmann]

Hm, could we align this with the autoopen/autoexec feature as implemented in keepass and keepass2droid?
Plugin KeeAutoExec for Keepass and Keepass2droid implement it the same way:

User name: Must contain the path to the key file, if one should be used. The path can be either absolute or relative to the directory containing KeePass.exe.
Password: The master password for the database to open. If no password is required, leave this field empty.
URL: Path to the database file to open. The path can be either absolute or relative to the directory containing KeePass.exe.

Additionally I already got this working with KeepassXC in the past, but it stopped working (regressed) with 2.4.2 or 2.4.3 (afair).

[metaphys]

I would rather wait to have more opinions before changing the code.
On one hand I do understand the importance of following other software standards.
On the other hand I find strange to use a field for something different than it's label (and yes this is already bugging me for URL).

Maybe a way to mitigate that would be to have a different editor for entry that are part of a AutoOpen group. This editor would just rename the label of those 2 fields so that the user see then as keyfile path and file path while actually saving them in regular Username and URL fields... would the current implementation allow such a change easily?

[droidmonkey]

If anything the url field is more appropriate for a file path

[metaphys]

Ok so I will move the key file pass to Username as suggested to follow standards. I'll leave the entry editor relabel for another PR

[droidmonkey]

We can support either a file path in username field OR URL field. Preference is username for backwards compatibility

[metaphys]

Well we need 2 files: the key and the database. So we need both field, each for one. If keepass and keepass2droid are already having this with keyfile in Username and DB in URL, I think that it would be a good idea to stick to it as @phurrelmann suggested...

[droidmonkey]

Oh oops, forgot the database was in the url field. Forget what I said

[metaphys]

ok am i ready for pulling, then? I don't know about my push to my local fork. I kind of made mess. I'm not very good at git :/ Do I need to merge those 3 commit into one or would the pulling concatenate them all together?

[droidmonkey]

Yah I got it from here, thanks!