only display advanced settings checkbox on tabs that have them (partially fixes #6190)

[xvallspl]

Current implementation has it disabled instead of hidden. Fixes #6190

In addition, it moves the checkbox into the only tab that has use for it, the Security->Encryption settings tab.

The scrolling bar is not working (yet)

Screenshots

Testing strategy

Went to each tab and checked every configuration

Type of change

• ✅ Bug fix (non-breaking change that fixes an issue)

[michaelk83]

From the linked issue:

If you only provide advanced settings for encryption, you should consider to move the checkbox away from the statusbar into the "Encryption Settings" panel, because the current UI design creates the impression this checkbox has a global effect on the entire settings dialog.

I think moving the checkbox to inside the relevant tab(s) would make more sense.

[xvallspl]

I am still trying to figure out how difficult it would be to move it inside the tabs. While these changes doesn't solve the awkwardness, they improve on the current solution. Maybe "Fixes" is a strong word.

[droidmonkey]

I would like it to be part of the Encryption page as well.

[xvallspl]

Moved the checkbox into the encryption tab, similar to Jonathan's suggestion. I removed several useless checks on the way.

I would still prefer to have all the settings in the same view, so I'll take a look at that.

[xvallspl]

Now simple and advanced settings share view with the checkbox toggling the visibility of the advanced ones. There's a need for a scroll area now, which would be in the next commit.

I was aiming for deleting more code than I introduce, but right now I'm exactly at 0. Make a wish.

[droidmonkey]

You'll want to disable the slide bar choosing the encryption time in your implementation when the advanced settings are shown.

[droidmonkey]

This has a crash on Linux ci that needs to be fixed.

[droidmonkey]

I made some emergency changes to stop the crashes. I think this needs a fair amount of work to be ready. There are a lot of extra calls to build the version drop down list and the UI elements are not properly sizing for me.

[xvallspl]

Ok! I was taking. Alook into this as well

[droidmonkey]

Rebased onto develop and tweaked the layout quite a bit:

[droidmonkey]

Made some more tweaks, this should be final:

Also removed the global setting that stored whether advanced was shown or not. That could inadvertently cause you to change encryption settings between multiple databases.

[codecov]

Codecov Report

Patch coverage: 97.56% and project coverage change: -0.01 ⚠️

Comparison is base (190a1fa) 64.82% compared to head (142744d) 64.81%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6513      +/-   ##
===========================================
- Coverage    64.82%   64.81%   -0.01%     
===========================================
  Files          343      337       -6     
  Lines        44613    44555      -58     
===========================================
- Hits         28918    28876      -42     
+ Misses       15695    15679      -16     

Impacted Files	Coverage Δ
src/core/Config.cpp	89.76% <ø> (ø)
src/core/Config.h	100.00% <ø> (ø)
src/gui/dbsettings/DatabaseSettingsDialog.h	100.00% <ø> (ø)
...gui/dbsettings/DatabaseSettingsWidgetMaintenance.h	0.00% <ø> (ø)
src/gui/settings/SettingsWidget.cpp	66.67% <ø> (-33.33%)	⬇️
src/gui/wizard/NewDatabaseWizardPage.cpp	83.33% <ø> (+2.25%)	⬆️
...ui/dbsettings/DatabaseSettingsWidgetEncryption.cpp	75.59% <97.50%> (+0.93%)	⬆️
src/gui/dbsettings/DatabaseSettingsDialog.cpp	93.55% <100.00%> (+0.50%)	⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.