Add Ctrl+Tab shortcut to cycle databases in unlock dialog #8168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main window has both `Ctrl+PageUp` / `Ctrl+PageDown` and `Ctrl+Tab / Ctrl+Shift+Tab` shortcuts to cycle the database tabs. When in PR keepassxreboot#5427 the abbility to select any open database in the unlock dialog was introduced, only the `Ctrl+PageUp` / `Ctrl+PageDown` shortcuts were added. This commit adds the `Ctrl+Tab / Ctrl+Shift+Tab` shortcuts to the unlock diaglog to fix this inconsistent UI behaviour. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Codecov Report
@@ Coverage Diff @@
## develop #8168 +/- ##
===========================================
- Coverage 64.48% 64.46% -0.02%
===========================================
Files 339 339
Lines 43699 43706 +7
===========================================
- Hits 28175 28172 -3
- Misses 15524 15534 +10
Continue to review full report at Codecov.
|
droidmonkey
approved these changes
Jun 19, 2022
ziegenberg
added a commit
to ziegenberg/keepassxc
that referenced
this pull request
Nov 25, 2022
When in PR keepassxreboot#8168 the abbility to cycle through the databases in the unlock dialog was extended to include the `Ctrl+Tab / Ctrl+Shift+Tab` shortcuts, it mixed up the direction. At the moment `Ctrl+Tab` selects the previous database, when customarily it should select the next entry. This was my mistake. This commit changes the direction of cycling through databases in the unlock dialog with `Ctrl+Tab / Ctrl+Shift+Tab` fixing my original commit. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main window has both
Ctrl+PageUp/Ctrl+PageDownandCtrl+Tab / Ctrl+Shift+Tabshortcuts to cycle the database tabs. When in PR #5427 the abbility to select any open database in the unlock dialog was introduced, only theCtrl+PageUp/Ctrl+PageDownshortcuts were added. This commit adds theCtrl+Tab / Ctrl+Shift+Tabshortcuts to the unlock diaglog to fix this inconsistent UI behaviour.Screenshots
None.
Testing strategy
I was able to compile and run the application.
Type of change