Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser: second fix for linked socket path #8704

Merged
merged 1 commit into from
Oct 29, 2022
Merged

Conversation

droidmonkey
Copy link
Member

Testing strategy

Tested on Ubuntu with 2.70 upgraded to this commit

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey
Copy link
Member Author

droidmonkey commented Oct 29, 2022

The only downside is that downgrading to anything less than 2.7.4 will break browser integration again. Maybe it is a good idea to remove this link when KeePassXC closes. @varjolintu thoughts? I am not overly concerned, but maybe adding to the troubleshooting guide for linux to manually delete the socket locations as a troubleshooting step.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2022

Codecov Report

Base: 64.43% // Head: 64.43% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (291ab89) compared to base (4030dbc).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8704      +/-   ##
===========================================
- Coverage    64.43%   64.43%   -0.00%     
===========================================
  Files          341      341              
  Lines        44246    44247       +1     
===========================================
  Hits         28507    28507              
- Misses       15739    15740       +1     
Impacted Files Coverage Δ
src/browser/BrowserShared.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@droidmonkey droidmonkey merged commit a5dee81 into develop Oct 29, 2022
@droidmonkey droidmonkey deleted the fix/browser-socket branch October 29, 2022 18:33
@varjolintu
Copy link
Member

@droidmonkey At least we've made sure the newer versions will work. I'll add a section about deleting the socket to the troubleshooting guide.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser connection is broken
4 participants