Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix print exported html #8986

Closed
wants to merge 1 commit into from
Closed

Fix print exported html #8986

wants to merge 1 commit into from

Conversation

dmaslenko
Copy link
Contributor

@dmaslenko dmaslenko commented Jan 13, 2023 •
edited
Loading

Fix #7769 by adjusting the html table width.

Screenshots

The generated html page looks fine now:
FixedHtmlPage1

The print preview page looks fine now:
FixedPrintPage1

Testing strategy

Manual testing

  • Created a test database with an entry with long notes (I took some paragraph from a wikipedia page).
  • Exported the database into HTML page.
  • Opened the generated html page by Firefox, Brave browsers.
  • Made sure the formatting is good.

Unit testing

  • Not applicable

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@dmaslenko
Fix print exported html
d7b2a5a 
[What]
  Adjusted the html table width.

[Why]
  To fit long notes on the generated html and print page.
@droidmonkey
Copy link
Member

Combine this into #8987

@dmaslenko dmaslenko deleted the fix/print_exported_html branch January 30, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print exported html - problem with Notes field
2 participants
@dmaslenko @droidmonkey