Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when using Windows Hello in a Remote Desktop session #9006

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Fix crash when using Windows Hello in a Remote Desktop session #9006

merged 1 commit into from
Feb 15, 2023

Commits on Feb 14, 2023

  1. Properly handle Windows Hello errors 

    The KeyCredentialManager::RequestCreateAsync call can fail because we can end up in a situation where Windows Hello is initially available but then becomes unavailable, such as during a remote desktop session. This commit prevents a crash by moving the call into the try-catch.

Fixes keepassxreboot#7890

Also resets quick unlock if there is an unrecoverable error. This will not occur if the user merely canceled the Windows Hello dialog.
    @Gibstick @droidmonkey
    Gibstick authored and droidmonkey committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    d422f38 View commit details
    Browse the repository at this point in the history