Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/database settings spin box bug #9101

Merged

Commits on Feb 11, 2023

  1. Fix DefaultHistoryMaxSize set in UI

    The default value in the Metadata is saved in Bytes while the UI shows the size in MB.
    Old code used the default in metadata as is, if database max size is unset the gui presents the default in bytes insted of MB which results in a huge number.
    This commit fixes this by adding the calculation to transform the value to MB.
    jNullj committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    7f5402b View commit details
    Browse the repository at this point in the history
  2. Fix DatabaseSettings UI SpinBoxs enable state

    SpinBoxes for items with disabled checkbox should not be enabled.
    If the user saves those settings as dissabled then reload the database the UI defaults to enable the SpinBox.
    This commit fixes this by setting enable to false if the setting checkbox is not checked.
    jNullj committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    dbd68b2 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2023

  1. Improve readability

    Values in DatabaseSettingsWidgetGeneral to convert from bytes to MB are written a more reabable way.
    jNullj committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    ec1dbf0 View commit details
    Browse the repository at this point in the history