Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

annotating inheriting classes may creates errors #7

Closed
ken-morel opened this issue May 24, 2024 · 2 comments
Closed

annotating inheriting classes may creates errors #7

ken-morel opened this issue May 24, 2024 · 2 comments
Assignees
@ken-morel
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right
Milestone
v1.1.3

Comments

@ken-morel
Copy link
Owner

No description provided.

@ken-morel ken-morel added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right labels May 24, 2024
@ken-morel ken-morel added this to the Class annotation support milestone May 24, 2024
@ken-morel ken-morel self-assigned this May 24, 2024
@ken-morel
Copy link
Owner Author

Due to it's way of working if the parent class did not yet try to give annotations, the when a daughter class have one of it's attribute assigned it may result in it having the wrong type

@ken-morel
Copy link
Owner Author

todo, for milestone v1.2.3, by default, if a class has no annotation for an attribute, the attribute won't be typechecked.

ken-morel added a commit that referenced this issue Jun 2, 2024
@ken-morel
Merge pull request #29 from ken-morel/ken-morel-patch-1
e4bbd81 
Reformated overload, now ignores non annotated class attributes, to repair #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ken-morel ken-morel

Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right
Projects
None yet
Milestone
v1.1.3
Development

No branches or pull requests
1 participant
@ken-morel