Skip to content

Commit

Permalink
test: Update Emscripten failures/passing
Browse files Browse the repository at this point in the history
All tests should now have annotation for *why* they're ignored on emscripten. A
few tests no longer need such an annotation as well!

Closes rust-lang#41299
  • Loading branch information
alexcrichton committed Oct 18, 2017
1 parent 0be6863 commit d9ecdfe
Show file tree
Hide file tree
Showing 55 changed files with 60 additions and 61 deletions.
8 changes: 4 additions & 4 deletions src/ci/docker/asmjs/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
COPY scripts/emscripten.sh /scripts/
RUN bash /scripts/emscripten.sh

COPY scripts/sccache.sh /scripts/
RUN sh /scripts/sccache.sh

ENV PATH=$PATH:/emsdk-portable
ENV PATH=$PATH:/emsdk-portable/clang/e1.37.13_64bit/
ENV PATH=$PATH:/emsdk-portable/emscripten/1.37.13/
Expand All @@ -28,7 +31,4 @@ ENV TARGETS=asmjs-unknown-emscripten

ENV RUST_CONFIGURE_ARGS --target=$TARGETS

ENV SCRIPT python2.7 ../x.py test --target $TARGETS

COPY scripts/sccache.sh /scripts/
RUN sh /scripts/sccache.sh
ENV SCRIPT python2.7 ../x.py test --target $TARGETS src/test/run-pass
2 changes: 1 addition & 1 deletion src/test/compile-fail/macro-expanded-include/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no asm! support

#![feature(asm, rustc_attrs)]
#![allow(unused)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/asm-concat-src.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// pretty-expanded FIXME #23616
// ignore-emscripten
// ignore-emscripten no asm

#![feature(asm)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/command-before-exec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// ignore-windows - this is a unix-specific test
// ignore-emscripten
// ignore-emscripten no processes

#![feature(process_exec, libc)]

Expand Down
3 changes: 2 additions & 1 deletion src/test/run-pass/command-exec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@

// ignore-windows - this is a unix-specific test
// ignore-pretty issue #37199
// ignore-emscripten
// ignore-emscripten no processes

#![feature(process_exec)]

use std::env;
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/core-run-destroy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// compile-flags:--test
// ignore-emscripten
// ignore-emscripten no processes

// NB: These tests kill child processes. Valgrind sees these children as leaking
// memory, which makes for some *confusing* logs. That's why these are here
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/env-args-reverse-iterator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no processes

use std::env::args;
use std::process::Command;
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/env-funky-keys.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

// ignore-android
// ignore-windows
// ignore-emscripten
// ignore-emscripten no execve
// no-prefer-dynamic

#![feature(libc)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/env-home-dir.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten env vars don't work?

#![feature(path)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/extern-pass-empty.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

// pretty-expanded FIXME #23616
// ignore-msvc
// ignore-emscripten
// ignore-emscripten emcc asserts on an empty struct as an argument

#[repr(C)]
struct TwoU8s {
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/fds-are-cloexec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

// ignore-windows
// ignore-android
// ignore-emscripten
// ignore-emscripten no processes
// ignore-haiku

#![feature(libc)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/format-no-std.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten missing rust_begin_unwind
// ignore-emscripten no no_std executables

#![feature(lang_items, start, alloc)]
#![no_std]
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/generator/smoke.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no threads support
// compile-flags: --test

#![feature(generators, generator_trait)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/i128.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten i128 doesn't work

#![feature(i128_type, test)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/issue-10626.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no processes

// Make sure that if a process doesn't have its stdio/stderr descriptors set up
// that we don't die in a large ball of fire
Expand Down
3 changes: 2 additions & 1 deletion src/test/run-pass/issue-13304.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no processes

#![feature(io, process_capture)]

use std::env;
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/issue-14456.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no processes

#![feature(io, process_capture)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/issue-14940.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no processes

use std::env;
use std::process::Command;
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/issue-16272.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no processes

use std::process::Command;
use std::env;
Expand Down
3 changes: 2 additions & 1 deletion src/test/run-pass/issue-20091.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no processes

#![feature(std_misc, os)]

#[cfg(unix)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/issue-2190-1.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// pretty-expanded FIXME #23616
// ignore-emscripten
// ignore-emscripten no threads

use std::thread::Builder;

Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/issue-24313.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no threads

use std::thread;
use std::env;
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/issue-28950.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no threads
// compile-flags: -O

// Tests that the `vec!` macro does not overflow the stack when it is
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/issue-29485.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:issue-29485.rs
// ignore-emscripten
// ignore-emscripten no threads

#[feature(recover)]

Expand Down
2 changes: 0 additions & 2 deletions src/test/run-pass/issue-29663.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@

// write_volatile causes an LLVM assert with composite types

// ignore-emscripten See #41299: probably a bad optimization

#![feature(volatile)]
use std::ptr::{read_volatile, write_volatile};

Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/issue-30490.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no processes

// Previously libstd would set stdio descriptors of a child process
// by `dup`ing the requested descriptors to inherit directly into the
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/issue-33770.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no processes

use std::process::{Command, Stdio};
use std::env;
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/linkage1.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

// ignore-windows
// ignore-macos
// ignore-emscripten
// ignore-emscripten doesn't support this linkage
// aux-build:linkage1.rs

#![feature(linkage)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/multi-panic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no processes

fn check_for_no_backtrace(test: std::process::Output) {
assert!(!test.status.success());
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/no-stdio.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no processes
// ignore-android

#![feature(libc)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/out-of-stack.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

// ignore-android: FIXME (#20004)
// ignore-musl
// ignore-emscripten
// ignore-emscripten no processes

#![feature(asm)]
#![feature(libc)]
Expand Down
2 changes: 0 additions & 2 deletions src/test/run-pass/packed-struct-layout.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
// ignore-emscripten Not sure what's happening here.


use std::mem;

Expand Down
2 changes: 0 additions & 2 deletions src/test/run-pass/packed-tuple-struct-layout.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
// ignore-emscripten


use std::mem;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// compile-flags:-C panic=abort
// aux-build:exit-success-if-unwind.rs
// no-prefer-dynamic
// ignore-emscripten Function not implemented
// ignore-emscripten no processes

extern crate exit_success_if_unwind;

Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/panic-runtime/abort.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

// compile-flags:-C panic=abort
// no-prefer-dynamic
// ignore-emscripten Function not implemented.
// ignore-emscripten no processes

use std::process::Command;
use std::env;
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/panic-runtime/lto-abort.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

// compile-flags:-C lto -C panic=abort
// no-prefer-dynamic
// ignore-emscripten Function not implemented.
// ignore-emscripten no processes

use std::process::Command;
use std::env;
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/panic-runtime/lto-unwind.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

// compile-flags:-C lto -C panic=unwind
// no-prefer-dynamic
// ignore-emscripten Function not implemented.
// ignore-emscripten no processes

use std::process::Command;
use std::env;
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/process-envs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no processes

use std::process::Command;
use std::env;
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/process-exit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no processes

use std::env;
use std::process::{self, Command, Stdio};
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/process-remove-from-env.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-emscripten
// ignore-emscripten no processes

use std::process::Command;
use std::env;
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/process-spawn-with-unicode-params.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// non-ASCII characters. The child process ensures all the strings are
// intact.

// ignore-emscripten
// ignore-emscripten no processes

use std::io::prelude::*;
use std::io;
Expand Down
3 changes: 2 additions & 1 deletion src/test/run-pass/process-status-inherits-stdin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
// ignore-emscripten Function not implemented.

// ignore-emscripten no processes

use std::env;
use std::io;
Expand Down
Loading

0 comments on commit d9ecdfe

Please sign in to comment.