This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Adding K3d installation instructions. #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StackScribe
reviewed
Mar 19, 2022
StackScribe
reviewed
Mar 19, 2022
Co-authored-by: Meg McRoberts <mmcroberts@cloudbees.com>
Co-authored-by: Meg McRoberts <mmcroberts@cloudbees.com>
StackScribe
reviewed
Mar 19, 2022
StackScribe
reviewed
Mar 19, 2022
Thank you for reviewing! I have committed your suggested changes. Is it ready to be merged then? |
Co-authored-by: Meg McRoberts <mmcroberts@cloudbees.com>
StackScribe
approved these changes
Mar 19, 2022
|
It needs review by a technical person but I approved it. |
|
@oleg-nenashev. Can you review it? Thank you! |
oleg-nenashev
suggested changes
Mar 20, 2022
subhamgcon
commented
Mar 20, 2022
There was a problem hiding this comment.
Can you please explain the requested changes? Also, should I start working on a PR for 0.14.x? @oleg-nenashev
You can update it in the same pull request. I think we can try reworking it later as experiment together with @StackScribe |
|
@oleg-nenashev Added the instructions in 0.14.x. |
oleg-nenashev
approved these changes
Mar 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #1121.
Signed-off by Subham Ghosh: subhamgcon@gmail.com