Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(operator): use List() when fetching KeptnWorkloadInstances for KeptnAppVersion #1456

Merged
merged 7 commits into from
May 25, 2023
Merged

chore(operator): use List() when fetching KeptnWorkloadInstances for KeptnAppVersion #1456

merged 7 commits into from
May 25, 2023

Conversation

odubajDT
Copy link
Contributor

Fixes: #1425

…KeptnAppVersion

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 603f0ed
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/646dde8124512c0008b45c80
😎 Deploy Preview https://deploy-preview-1456--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #1456 (59deac4) into main (a20b2e7) will increase coverage by 0.20%.
The diff coverage is 58.33%.

❗ Current head 59deac4 differs from pull request most recent head da2c0ba. Consider uploading reports for the commit da2c0ba to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1456      +/-   ##
==========================================
+ Coverage   61.61%   61.81%   +0.20%     
==========================================
  Files         137      137              
  Lines       10456    10488      +32     
==========================================
+ Hits         6442     6483      +41     
+ Misses       3763     3755       -8     
+ Partials      251      250       -1     
Impacted Files Coverage Δ
...lers/lifecycle/keptnworkloadinstance/controller.go 81.73% <50.00%> (+0.51%) ⬆️
...ecycle/keptnappversion/reconcile_workloadsstate.go 75.71% <59.52%> (+27.98%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.04% <6.52%> (-1.51%) ⬇️
lifecycle-operator 83.51% <54.34%> (+0.12%) ⬆️
metrics-operator 80.51% <ø> (ø)
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT marked this pull request as ready for review May 24, 2023 13:49
@odubajDT odubajDT requested a review from a team as a code owner May 24, 2023 13:49
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
bacherfl
bacherfl previously approved these changes May 25, 2023
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.7% 4.7% Duplication

@odubajDT odubajDT merged commit ecd8c48 into keptn:main May 25, 2023
@keptn-bot keptn-bot mentioned this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look up KeptnWorkloadInstances for a KeptnAppVersion using LIST request
3 participants