-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document timeframe
feature for KeptnMetric
#1703
docs: document timeframe
feature for KeptnMetric
#1703
Conversation
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rakshitgondwal thanks for adding docs! Could you also update the metrics examples availabels at metrics-operator/config/samples ?
Sure will do, should I also make the changes to |
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1703 +/- ##
==========================================
+ Coverage 63.46% 63.55% +0.09%
==========================================
Files 143 143
Lines 10908 10908
==========================================
+ Hits 6923 6933 +10
+ Misses 3722 3715 -7
+ Partials 263 260 -3 see 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
@rakshitgondwal I think you could squeeze that change here as well yes! Thankyou 🚀 |
metrics-operator/config/samples/metrics_v1alpha1_keptnmetric.yaml
Outdated
Show resolved
Hide resolved
metrics-operator/config/samples/metrics_v1alpha2_keptnmetric.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work :)
Fixes #1702
Updated https://main.lifecycle.keptn.sh/docs/yaml-crd-ref/metric/ to support the
range.interval
field.