Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change releases link to get started in mainpage header menu #1738

Merged
merged 3 commits into from
Jul 25, 2023
Merged

docs: change releases link to get started in mainpage header menu #1738

merged 3 commits into from
Jul 25, 2023

Conversation

agardnerIT
Copy link
Contributor

This PR:

  • Removed the Releases link in favour of a "getting started" link

Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
@agardnerIT agardnerIT requested review from a team as code owners July 19, 2023 23:33
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 19, 2023
@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 1d70ca0
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64b9a9fabae9e50008825c2c
😎 Deploy Preview https://deploy-preview-1738--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@agardnerIT agardnerIT changed the title Change releases link to get started chore: Change releases link to get started Jul 19, 2023
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
@agardnerIT agardnerIT changed the title chore: Change releases link to get started chore: change releases link to get started Jul 19, 2023
@StackScribe
Copy link
Contributor

I like this. Then we can work to improve the Getting Started doc appropriately.

However, I think that button is the only access to the Release Notes. Should we add that to the top toolbar or perhaps to the docs landing page? I would favor the latter -- similar to what we had for Keptn v1. @thisthat , what do you think?

thisthat
thisthat previously approved these changes Jul 20, 2023
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@agardnerIT
Copy link
Contributor Author

@StackScribe I've added a link to GitHub on the top menu bar. Does this help?

image

@mowies mowies changed the title chore: change releases link to get started docs: change releases link to get started in mainpage header menu Jul 25, 2023
@mowies mowies merged commit 1f9ea33 into keptn:main Jul 25, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants