-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add helm chart support (PoC) #489
Closed
philipp-hinteregger
wants to merge
9
commits into
keptn:main
from
philipp-hinteregger:poc/add-helm-charts
Closed
chore: add helm chart support (PoC) #489
philipp-hinteregger
wants to merge
9
commits into
keptn:main
from
philipp-hinteregger:poc/add-helm-charts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Hinteregger <philipp.hinteregger@dynatrace.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
===========================================
- Coverage 59.54% 48.78% -10.76%
===========================================
Files 28 55 +27
Lines 2101 5143 +3042
===========================================
+ Hits 1251 2509 +1258
- Misses 745 2527 +1782
- Partials 105 107 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Philipp Hinteregger <philipp.hinteregger@dynatrace.com>
Signed-off-by: Philipp Hinteregger <philipp.hinteregger@dynatrace.com>
Signed-off-by: Philipp Hinteregger <philipp.hinteregger@dynatrace.com>
Signed-off-by: Philipp Hinteregger <philipp.hinteregger@dynatrace.com>
Signed-off-by: Philipp Hinteregger <philipp.hinteregger@dynatrace.com>
Signed-off-by: Philipp Hinteregger <philipp.hinteregger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
philipp-hinteregger
changed the title
chore: add helm chart support
chore: add helm chart support (PoC)
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Questions from the Issue
It's possible that in the future some Kustomize patches would be required, adding more complexity than this example. This adds a lot of complexity and will have an impact on the maintainability.
overlays/helm/kustomization.yaml
, e.g. namespace like in this example_helpers.tpl
filevalues.yaml
fileThis will use the rendered mainfest file and replace the values defined in the
kustomization.yaml
with the respective templating functions of the_helpers.tpl
. While rendering the chart, Helm will replace the templating values with the values provided in thevalues.yaml
file. However, this is a rather simple example. A rather complex approach is using Kustomize patches. In that case, a respective patch file needs to be created (like in this PoC) to match the required resource and the target property.Signed-off-by: Philipp Hinteregger philipp.hinteregger@dynatrace.com