Merge pull request #20 from kishaningithub/prevent-duplicate-matches

Prevent duplicate imports when importing multiple addresses

pkg/internal/parser/parser.go

@@ -17,13 +17,24 @@ func (resources TerraformResources) FilterByAddresses(addresses []string) Terraf
 	for _, resource := range resources {
 		for _, address := range addresses {
 			if strings.HasPrefix(resource.Address, address) {
-				filteredResources = append(filteredResources, resource)
+				if !filteredResources.contains(resource) {
+					filteredResources = append(filteredResources, resource)
+				}
 			}
 		}
 	}
 	return filteredResources
 }
 
+func (resources TerraformResources) contains(r TerraformResource) bool {
+	for _, resource := range resources {
+		if resource.Address == r.Address {
+			return true
+		}
+	}
+	return false
+}
+
 type TerraformStateParser interface {
 	Parse() (TerraformResources, error)
 }

pkg/tfimportgen_test.go

@@ -209,3 +209,38 @@ func Test_GenerateImports_ShouldGenerateImportsForResourcesForMultipleAddresses(
 		})
 	}
 }
+
+func Test_GenerateImports_ShouldNotGenerateDuplicateImportsForResourcesForMultipleAddresses(t *testing.T) {
+	tests := []struct {
+		name     string
+		address  []string
+		expected tfimportgen.TerraformImports
+	}{
+		{
+			name:    "filtering by module",
+			address: []string{"aws_glue_catalog_database.test_db", "aws_glue_catalog_database.test_db"},
+			expected: tfimportgen.TerraformImports{
+				{
+					ResourceAddress: "aws_glue_catalog_database.test_db",
+					ResourceID:      "id_test_db",
+					SupportsImport:  true,
+				},
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			stateJsonFile, err := os.Open(filepath.FromSlash("testdata/resources_in_root_and_child_modules.json"))
+			require.NoError(t, err)
+			t.Cleanup(func() {
+				_ = stateJsonFile.Close()
+			})
+
+			actual, err := tfimportgen.GenerateImports(stateJsonFile, tt.address)
+
+			require.NoError(t, err)
+			require.Equal(t, tt.expected, actual)
+		})
+	}
+}