Add -o bashdefault to register-python-argcomplete's output command #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 82.69% 82.69%
=======================================
Files 7 7
Lines 734 734
=======================================
Hits 607 607
Misses 127 127
Continue to review full report at Codecov.
|
2 tasks
argcomplete/shell_integration.py
Outdated
| @@ -74,7 +74,7 @@ def shellcode(executables, use_defaults=True, shell='bash', complete_arguments=N | |||
| ''' | |||
|
|
|||
| if complete_arguments is None: | |||
| complete_options = '-o nospace -o default' if use_defaults else '-o nospace' | |||
| complete_options = '-o nospace -o default -o bashdefault' if use_defaults else '-o nospace' | |||
There was a problem hiding this comment.
We should also include -o bashdefault when use_defaults is False to match the behaviour of the global completion script.
There was a problem hiding this comment.
Nice catch. Added as requested.
|
Perfect, thanks! |
|
Released in v1.11.1, please test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #67 (comment)
Add
-o bashdefaulttoregister-python-argcomplete's output command, so that individual command can complete the environment variables.