Skip to content

Commit

Permalink
Stop printing passwords
Browse files Browse the repository at this point in the history
  • Loading branch information
kj4ezj committed Feb 26, 2024
1 parent 3f1b51e commit 534446f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ docker kill "$(docker ps | tail -1 | awk '{print $1}')"
```
For this reason and others, the wrapper will be removed in a subsequent version. If you plan to rely upon it, please pull your container by `git` tag.

To prevent your password from ending up in a bunch of logs (or worse), `zap2xml` no longer prints the arguments it sees when it starts by default. If you need this for debugging, set:
```bash
export DEBUG='true'
```
It always prints the `argc` so you can tell if it is seeing the correct number of arguments without exposing your password.

## Development
Contributors need these tools installed.
- [act](https://github.com/nektos/act)
Expand Down
4 changes: 3 additions & 1 deletion zap2xml.pl
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@
$VERSION = "2018-12-01";
print "zap2xml ($VERSION)\n";
print "argc: " . ($#ARGV + 2) . "\n";
print "argv: [" . join(", ", map { "\"$_\"" } ($0, @ARGV)) . "]\n";
if ($ENV{DEBUG} eq 'true') {
print "argv: [" . join(", ", map { "\"$_\"" } ($0, @ARGV)) . "]\n";
}

%options=();
getopts("?aA:bB:c:C:d:DeE:Fgi:IjJ:l:Lm:Mn:N:o:Op:P:qRr:s:S:t:Tu:UwWxY:zZ:89",\%options);
Expand Down

0 comments on commit 534446f

Please sign in to comment.