Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shorter URL with env variables #39

Merged
merged 3 commits into from
Jul 18, 2019

Conversation

mastix
Copy link
Contributor

@mastix mastix commented Jul 15, 2019

I needed a way to use shorter URLs for my podcast server.

Currently it would look like this:

podcast.myowndomain.com/projectId/datasource/slug/rss

I'd like to pass the data from the path as env variable to the server, so my .env contains the projectID, the datasource and the slug name.

So now I can use the following URL (and the mandatory information is being picked up from the env variables):

podcast.myowndomain.com/rss

I think this is a cool feature.

Sascha

@mastix
Copy link
Contributor Author

mastix commented Jul 15, 2019

@kmelve , I've also wrapped your server into a Docker Image, which has now be published to the Docker Hub. This container now runs on my server, therefore it would be great if you could merge my pull requests. :)

See: https://github.com/mastix/sanity-podcast-server-docker

@mastix
Copy link
Contributor Author

mastix commented Jul 18, 2019

@kmelve, are you considering to pull my requests? Otherwise I would keep and develop my fork separated from yours. Please let me know asap! 👍

@kmelve kmelve merged commit 54fbdc0 into kmelve:master Jul 18, 2019
@kmelve
Copy link
Owner

kmelve commented Jul 18, 2019

Thanks for the contribution @mastix, and sorry for the wait!

@mastix
Copy link
Contributor Author

mastix commented Jul 18, 2019

@kmelve No problem! It's just like when project don't want my contributions then I'll usually start to work on my own fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants