Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new ClusterAdmin at each loop #63

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Create a new ClusterAdmin at each loop #63

merged 2 commits into from
Jul 28, 2020

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Jul 27, 2020 •
edited
Loading

Fix sarama issue: IBM/sarama#1565 (in our case is ClusterAdmin, we have the same error though)

Proposed Changes

  • Create a new ClusterAdmin at each loop

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 27, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 27, 2020
@pierDipi
Create a new ClusterAdmin at each loop
f6cbd4d 
- Fix sarama issue: IBM/sarama#1565

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi pierDipi force-pushed the create-new-cluster-admin-each-loop branch from 06495ad to f6cbd4d Compare July 27, 2020 18:09
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@pierDipi
Remove error return value from SetBootstrapServer
675f557 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@slinkydeveloper
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
control-plane/pkg/reconciler/broker/broker.go 90.8% 92.1% 1.3
control-plane/pkg/reconciler/broker/topic.go 100.0% 91.7% -8.3

@knative-prow-robot knative-prow-robot merged commit bfbeb90 into knative-extensions:master Jul 28, 2020
@pierDipi pierDipi deleted the create-new-cluster-admin-each-loop branch April 14, 2021 21:17
matzew pushed a commit to matzew/eventing-kafka-broker that referenced this pull request Mar 17, 2022
@mgencur
Use Broker's own configmap for Kafka (knative-extensions#63)
6e189b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slinkydeveloper slinkydeveloper slinkydeveloper approved these changes

@matzew matzew Awaiting requested review from matzew

Assignees

@slinkydeveloper slinkydeveloper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pierDipi @knative-prow-robot @slinkydeveloper @knative-metrics-robot @googlebot