Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config-bootstrapper and test-runner RBAC #3672

Merged
merged 5 commits into from
Jan 17, 2023
Merged

Fix config-bootstrapper and test-runner RBAC #3672

merged 5 commits into from
Jan 17, 2023

Conversation

upodroid
Copy link
Member

/cc @dprotaso @kvmware

1st commit fixes the e2e serving errors @dprotaso mentioned
2nd commit fixes the config-bootstrapper errors. Basically, it was pointing to the old prow control plane cluster which I deleted this month.

Contents of the kubeconfig:

 REDACTED  C02CW0CDP3YY  ~  $  kg secret -n test-pods prow-kubeconfig -o yaml | yq '.data."kubeconfig.yaml"' | base64 -d | yq .contexts
- context:
    cluster: prow-build
    user: prow-build
  name: prow-build
- context:
    cluster: prow-trusted
    user: prow-trusted
  name: prow-trusted
- context:
    cluster: prow-control-plane
    user: prow-control-plane
  name: prow-control-plane

I'm working with sig-testing at Kubernetes on getting rid of the bearer tokens and using the gke auth plugins.

kubernetes/test-infra#28142

@knative-prow
Copy link

knative-prow bot commented Jan 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Jan 17, 2023

You have some no newline issues else lgtm

@upodroid
Copy link
Member Author

/hold

I had to revert my change earlier. Prow unfortunately doesn't understand different contexts properly. It assumes all users have cluster-admin which isn't good.

First order of business is extending config-bootstrapper to use a context.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2023
@upodroid
Copy link
Member Author

A quick fix would be to load a kubeconfig with just only the config-bootstrapper context.

@upodroid
Copy link
Member Author

Also, it is 7 days till the release day so I don't really want to make some changes this week and cause testgrid to show extra flakes from infra changes/snafu

@upodroid
Copy link
Member Author

/hold cancel

I created a dedicated secret for it with just a single context. I will experiment with the contexts after the release is done.

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Jan 17, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
@knative-prow knative-prow bot merged commit e4e38a7 into knative:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants