Provide generic type params #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarkHerhold would you mind to take a look? thanks |
|
@MarkHerhold @dlau I would like these to be merged in as well |
|
This should be at least partially addressed by #213 |
|
I'll check that out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the return type of
koaBody()has been fixed toKoa.Middleware<{}, {}>, which will be problematic if we would like to provide a different type combo, e.g.:this pr will fix this issue by providing generic type params:
since
koaBody()will injectbodyandfilesintoctx.requestdirectly, it'll be fine to just keep the same input type combo for the return middleware function.