Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade eslint to v9.10.0 #191

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

chore: upgrade eslint to v9.10.0 #191

wants to merge 14 commits into from

Conversation

iambumblehead
Copy link

hello, this PR updates eslint to version 9.10.0 so npm install no longer shows red audit warning messages.

  • eslint 9 requires "eslint.config.js" added here,
  • xo is removed because it does not support eslint 9 Upgrade to ESLint 9 xojs/xo#757,
  • eslint-config-xo-lass exports an eslint 8 config, however its "rules" are usable with eslint 9 here,
  • unicorn is added as adependency, because some of its eslint rules are used by eslint-config-xo-lass,
  • many new and maybe pre-existing lint errors are raised --no effort is made to resolve the errors in this PR,
  • npm run lint fails because of the lint errors --no effort is made to resolve this,
  • because npm run lint fails, the husky commit hook fails

Hopefully this PR will be useful so that project owners may apply any remaining changes in ways they prefer.

Thank you :)

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

vikiboss and others added 14 commits April 9, 2024 20:21
@vikiboss
docs: correct npm link reference in readme (koajs#174)
cdf8ec4
@laverdet
fix: undefined property in unmatched host (koajs#178)
31deae8
@3imed-jaberi
Refactor to use native Node.js modules, support Node.js v20+ and mode…
f7ffb93 
…rnize the code (koajs#180)

* refactor: upgrade deps + refactor code to be with oop class style + support node.js 20+ ...etc

* fix: add fix for koajs#179 issue
@3imed-jaberi
refactor: support Node.js v18+ and replace the debug module with nati…
83d2b34 
…ve Node.js one (koajs#181)
@titanism
13.0.0
9b7339d
@mschfh
fix: bump path-to-regexp to 6.3.0 (koajs#187)
e19c62b 
Resolves koajs#186
@lbesson-della
fix: allowedMethods() should not fail if more than one router is defi…
76020dd 
…ned (koajs#183)

Fixes koajs#182
@harryby1149
Chore: Update path-to-regex to v8.1.0 (koajs#189)
b5b08ba 
* chore: upgrade path-to-regex to v8.1.0

* chore: upgrade path-to-regex to v8.1.0

* chore: clean up test syntax

* chore: clean up whitespace changes

* chore: use String constructor instead of .toString for type conversion
@harryby1149
chore: pass trailing option to pathToRegexp call when strict is true (k…
5ce4e19 
…oajs#190)
@titanism
13.0.1
0b184f9
@titanism
fix: fixed repo url
3d5b04d
@titanism
Revert "13.0.1"
3a15824 
This reverts commit 0b184f9.
@titanism
13.0.1
c93c2af
@bumblehead
chore: upgrade eslint to v9.10.0
27f9124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@iambumblehead @titanism @vikiboss @laverdet @3imed-jaberi @mschfh @lbesson-della @harryby1149 @bumblehead