Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Signing modal consistency #9002

Merged
merged 44 commits into from
Jan 26, 2024
Merged

feat: Signing modal consistency #9002

merged 44 commits into from
Jan 26, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jan 15, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

new signing modal added to:

  • create nft
  • create collection
  • buy modal
  • teleport
  • transfer nft
  • listing modal
  • holder of generative
  • burn nft
  • burn collection
  • burn all nfts of collection

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-01-15 at 15 13 38@2x

Copy link

netlify bot commented Jan 15, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c9df787
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65af914e5178ba0008b1494f
😎 Deploy Preview https://deploy-preview-9002--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Jan 15, 2024

SUCCESS @hassnian PR for issue #8904 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link
Contributor

reviewpad bot commented Jan 15, 2024

AI-Generated Summary: This pull request introduces a new signing modal feature in various components including creating NFTs, creating collections, buying NFTs, bridging the currency, transferring NFTs, minting generative drops and burning NFTs. The patches also update the related language locales to accommodate the changes brought in by the new signing modal. Additionally, there are several changes relating to replacements of the Loader component with the SigningModal component. The settings for the SigningModal have been specified according to each particular use case. The patches also involve the introduction of new language keys and small fixes to ensure the setting of properties fits the business rules correctly.

@reviewpad reviewpad bot added the medium Pull request is medium label Jan 15, 2024
@exezbcz
Copy link
Member

exezbcz commented Jan 15, 2024

question: is it also done so that when you are mass listing, it adds "s" to the copy

image
  • so there would be listing NFTs

@hassnian
Copy link
Contributor Author

hassnian commented Jan 15, 2024

question: is it also done so that when you are mass listing, it adds "s" to the copy

image * so there would be listing NFTs

yes , listing and buying

@hassnian hassnian marked this pull request as ready for review January 15, 2024 12:02
@hassnian hassnian requested a review from a team as a code owner January 15, 2024 12:02
@hassnian hassnian removed the request for review from a team January 15, 2024 12:02
@reviewpad reviewpad bot removed the medium Pull request is medium label Jan 21, 2024
@reviewpad reviewpad bot added the large Pull request is large label Jan 21, 2024
@hassnian
Copy link
Contributor Author

CleanShot.2024-01-20.at.17.11.01.mp4

@roiLeo @preschian added try again feature , review again if needed

  • cancelling transaction still does not work

@exezbcz was not added, pls try now

Copy link

codeclimate bot commented Jan 23, 2024

Code Climate has analyzed commit c9df787 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yangwao
Copy link
Member

yangwao commented Jan 23, 2024

we can hold this one for this week release as it's not well tested and we don't want to break something.

@yangwao
Copy link
Member

yangwao commented Jan 26, 2024

I think it's over drop and we can push it to beta so we can collectively test out

Otherwise it would needs consistently maintain conflicts

Agree?

@yangwao
Copy link
Member

yangwao commented Jan 26, 2024

Thanks!
pay 90 usd

@yangwao yangwao merged commit 918139b into kodadot:main Jan 26, 2024
15 checks passed
@yangwao
Copy link
Member

yangwao commented Jan 26, 2024

😍 Perfect, I’ve sent the payout
💵 $90 @ 6.56 USD/DOT ~ 13.72 $DOT
🧗 13QUj3pZyFNfYj4AM336hRdyLQbevj5H3sR4PKmLEXLdwZhh
🔗 0x4a8b241b2d340e2597ce769dbf5ef06a6a14b6114f3f2079c3c1cdf7a4c8b812

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large paid pull-request has been paid S-changes-requested-🤞 PR is almost good to go, just some fine tunning waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signing modal consistency
6 participants