Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No alpha overloads for {symmetric,hermitian}_matrix_rank_1_update #156

Closed
mzuzek opened this issue Apr 6, 2022 · 2 comments · Fixed by #264
Closed

No alpha overloads for {symmetric,hermitian}_matrix_rank_1_update #156

mzuzek opened this issue Apr 6, 2022 · 2 comments · Fixed by #264

Comments

@mzuzek
Copy link

mzuzek commented Apr 6, 2022 •
edited
Loading

@mhoemmen @fnrizzi

It seems that alpha overloads of symmetric_matrix_rank_1_update() and hermitian_matrix_rank_1_update() are missing in the current main.

Note: alpha overloads were introduced in R2 and no-alpha overloads were removed in R4 (see revision history) because of template ambiguity issue (see #134, #136, #138 and #139).
@mzuzek
Copy link
Author

mzuzek commented Apr 6, 2022

Does this duplicate #138 ?

@mhoemmen mhoemmen mentioned this issue Jan 16, 2024
Merged
@mhoemmen
Copy link
Contributor

PR #263 (merged) fixes symmetric_matrix_rank_1_update. PR #264 will fix hermitian_matrix_rank_1_update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix hermitian_matrix_rank_1_update mhoemmen/stdBLAS
2 participants
@mhoemmen @mzuzek