Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rank_k_update: remove ambiguity, #134, #136 #139

Closed

Conversation

fnrizzi
Copy link
Contributor

@fnrizzi fnrizzi commented Dec 15, 2021

@mhoemmen this should fix #136

@mhoemmen
Copy link
Contributor

Thanks for the fix! @crtrott asked us to investigate whether it's possible to constrain alpha so that we can keep the overloads. Would you consider trying out this investigation? I think we would just have to add a requires clause that includes alpha in the algorithm's "mathematical expression" (that's a phrase I define in P1673, meaning "the expression that needs to compile and make semantic sense, for that algorithm").

@fnrizzi
Copy link
Contributor Author

fnrizzi commented Dec 15, 2021

@mhoemmen yes I definitely I am up to look at it if @crtrott approves me looking at it since he is in charge of my work :)

@fnrizzi
Copy link
Contributor Author

fnrizzi commented Mar 30, 2022

as soon as I move to blas3, i will take this on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix {symmetric,hermitian}_matrix_rank_k_update ambiguity
2 participants