Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix symmetric_matrix_rank_k_update, hermitian_matrix_rank_k_update, and symmetric_matrix_rank_1_update #263

Merged
merged 11 commits into from
Jan 16, 2024
Merged

Fix symmetric_matrix_rank_k_update, hermitian_matrix_rank_k_update, and symmetric_matrix_rank_1_update #263

merged 11 commits into from
Jan 16, 2024

Commits on Jan 13, 2024

  1. Fix tests build for submdspan 

    Header and namespace seem to have changed since last time.
    @mhoemmen
    mhoemmen committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    d2d38fd View commit details
    Browse the repository at this point in the history

  2. Add Issue kokkos#261 regression test; it fails to build

    @mhoemmen
    mhoemmen committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    d0938f3 View commit details
    Browse the repository at this point in the history

  3. Fix kokkos#261 

    Constrain symmetric_matrix_rank_k_update ExecutionPolicy overloads
so that the compiler can distinguish them from alpha overloads.
    @mhoemmen
    mhoemmen committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    11a15e3 View commit details
    Browse the repository at this point in the history

  4. Fix symmetric_matrix_rank_k_update algorithm 

    Algorithm was giving incorrect results.
This commit fixes that and
improves the associated regression test.
    @mhoemmen
    mhoemmen committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    4eaebd5 View commit details
    Browse the repository at this point in the history

  5. Fix hermitian_matrix_rank_k_update ambiguous overloads 

    Add a regression test that didn't build before this change,
and now builds correctly.
    @mhoemmen
    mhoemmen committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    e3425fe View commit details
    Browse the repository at this point in the history

  6. Fix hermitian_matrix_rank_k_update 

    1. Fix ambiguous overload for the no-scalar case
2. Fix the algorithm (so it gives the right answer,
   for both the scalar and no-scalar cases)
    @mhoemmen
    mhoemmen committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    6cd9fb0 View commit details
    Browse the repository at this point in the history

  7. Refactor hermitian_matrix_rank_k_update test

    @mhoemmen
    mhoemmen committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    7681c65 View commit details
    Browse the repository at this point in the history

  8. Fix symmetric_matrix_rank_k_update 

    1. Fix ambiguous overload for the no-scalar case
2. Fix the algorithm (so it gives the right answer
   for the no-scalar case; the with-scalar case
   was already fixed in a previous commit)
    @mhoemmen
    mhoemmen committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    4c9089a View commit details
    Browse the repository at this point in the history

  9. Add trait for custom execution policies 

    Add a new trait for testing whether an ExecutionPolicy is a valid
execution policy (either std::is_execution_policy_v or custom).
Use it in symmetric_matrix_rank_k_update and
hermitian_matrix_rank_k_update.
    @mhoemmen
    mhoemmen committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    cfeddcd View commit details
    Browse the repository at this point in the history

  10. Fix symmetric_matrix_rank_1_update ambiguous overloads 

    The reference implementation needs to implement all constraints of
symmetric_matrix_rank_1_update in order to disambiguate overloads.

Add a regression test as well.
    @mhoemmen
    mhoemmen committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    592c6af View commit details
    Browse the repository at this point in the history

  11. Respond to review feedback

    @mhoemmen
    mhoemmen committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    0e66c12 View commit details
    Browse the repository at this point in the history