Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load: don't ignore Sscanf errors #7

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Load: don't ignore Sscanf errors #7

merged 1 commit into from
Jul 29, 2024

Conversation

kolyshkin
Copy link
Owner

@kolyshkin kolyshkin commented Jul 24, 2024

This fixes errcheck linter warnings:

capability_linux.go:311:14: Error return value of `fmt.Sscanf` is not checked (errcheck)
			fmt.Sscanf(line[4:], "nd:  %08x%08x", &c.bounds[1], &c.bounds[0])
			          ^
capability_linux.go:315:14: Error return value of `fmt.Sscanf` is not checked (errcheck)
			fmt.Sscanf(line[4:], "mb:  %08x%08x", &c.ambient[1], &c.ambient[0])
			          ^

Once this (and #6) are merged, I can add basic CI.

This fixes errcheck linter warnings:

> capability_linux.go:311:14: Error return value of `fmt.Sscanf` is not checked (errcheck)
> 			fmt.Sscanf(line[4:], "nd:  %08x%08x", &c.bounds[1], &c.bounds[0])
> 			          ^
> capability_linux.go:315:14: Error return value of `fmt.Sscanf` is not checked (errcheck)
> 			fmt.Sscanf(line[4:], "mb:  %08x%08x", &c.ambient[1], &c.ambient[0])
> 			          ^

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin merged commit 2926cc7 into main Jul 29, 2024
@kolyshkin kolyshkin deleted the linter branch August 1, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant