Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KFLUXBUGS-1614): fbc pipeline should stop passing binaryImage to iib #553

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

theflockers
Copy link
Contributor

this commit removes the binaryImage reference from FBC Release pipeline and tasks so the IIB build can auto resolve it.

Copy link

openshift-ci bot commented Sep 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@theflockers
Copy link
Contributor Author

/test all

@theflockers
Copy link
Contributor Author

johnbieren
johnbieren previously approved these changes Sep 17, 2024
mmalina
mmalina previously approved these changes Sep 17, 2024
this commit removes the binaryImage reference from FBC Release pipeline
and tasks so the IIB build can auto resolve it.

Signed-off-by: Leandro Mendes <lmendes@redhat.com>
Copy link

openshift-ci bot commented Sep 18, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Sep 18, 2024

@theflockers: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/release-pipelines-e2e-suite 1aa9f72 link true /test release-pipelines-e2e-suite

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@@ -68,7 +65,6 @@ spec:
# Access the updated image
updatedFromIndex=$(replace_tag "$(jq -r '.fbc.fromIndex' "$DATA_FILE")")
updatedTargetIndex=$(replace_tag "$(jq -r '.fbc.targetIndex' "$DATA_FILE")")
updatedBinaryImage=$(replace_tag "$(jq -r '.fbc.binaryImage' "$DATA_FILE")")

# if {{OCP_VERSION}} is not set, the original Index will be kept but its ocp version should
# match base image version.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two lines below this needs to be removed too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants