-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(KFLUXBUGS-1614): fbc pipeline should stop passing binaryImage to iib #553
base: development
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
583dcb9
to
346a93a
Compare
346a93a
to
6bc56fa
Compare
/test all |
43cd46d
to
18dd6df
Compare
Depends on: hacbs-release/app-interface-deployments#185 |
this commit removes the binaryImage reference from FBC Release pipeline and tasks so the IIB build can auto resolve it. Signed-off-by: Leandro Mendes <lmendes@redhat.com>
1aa9f72
18dd6df
to
1aa9f72
Compare
New changes are detected. LGTM label has been removed. |
@theflockers: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@@ -68,7 +65,6 @@ spec: | |||
# Access the updated image | |||
updatedFromIndex=$(replace_tag "$(jq -r '.fbc.fromIndex' "$DATA_FILE")") | |||
updatedTargetIndex=$(replace_tag "$(jq -r '.fbc.targetIndex' "$DATA_FILE")") | |||
updatedBinaryImage=$(replace_tag "$(jq -r '.fbc.binaryImage' "$DATA_FILE")") | |||
|
|||
# if {{OCP_VERSION}} is not set, the original Index will be kept but its ocp version should | |||
# match base image version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two lines below this needs to be removed too
this commit removes the binaryImage reference from FBC Release pipeline and tasks so the IIB build can auto resolve it.