types: more general type hint for type_hooks #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a test to help ensure that type_hooks continues to work with a very general Mapping implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the type hint for type_hooks to accept the more general
Mappingrather thanDict. It looks liketransform_valuewill work with anytype_hooksthat supports__getitem__, which the Mapping ABC / type signature requires that users do.This makes the typechecker happier with us since I want to start using a Mapping implementation for a type_hooks that we use, to allow a little more flexibility. I can't think of any particular drawbacks to having a more general type hint here.
Out of self-interest, I added a test which I think will ensure dacite continues to support the use case I have in mind (tests a Mapping which is exactly like a dict but has an augmented
__getitem__method).