Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 adding timeout for RPC call #678

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

shawn-hurley
Copy link
Contributor

This cuased a problem when the language server is OOM killed and the read step was always waiting causing an indefinite hang. This will timeout these requests.

@shawn-hurley shawn-hurley added the cherry-pick/release-0.5 This PR should be cherry-picked to release-0.4 branch. label Jul 29, 2024
Signed-off-by: Shawn Hurley <shawn@hurley.page>
@shawn-hurley shawn-hurley merged commit fb8315c into konveyor:main Jul 29, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
This cuased a problem when the language server is OOM killed and the
read step was always waiting causing an indefinite hang. This will
timeout these requests.

Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Cherry Picker <noreply@github.com>
shawn-hurley added a commit that referenced this pull request Jul 29, 2024
This cuased a problem when the language server is OOM killed and the
read step was always waiting causing an indefinite hang. This will
timeout these requests.

Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Cherry Picker <noreply@github.com>

Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Cherry Picker <noreply@github.com>
Co-authored-by: Shawn Hurley <shawn@hurley.page>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.5 This PR should be cherry-picked to release-0.4 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants