✨ Reaper optimization. #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jortel
force-pushed
the
reaper-optimization
branch
from
5e01fd7
to
2c4df5e
Compare
Signed-off-by: Jeff Ortel <jortel@redhat.com>
jortel
force-pushed
the
reaper-optimization
branch
from
2c4df5e
to
cdbbb21
Compare
jortel
commented
Jun 26, 2024
| for _, m := range []any{ | ||
| &model.Task{}, | ||
| &model.TaskReport{}, | ||
| &model.RuleSet{}, |
There was a problem hiding this comment.
hint: RuleSet removed because it does not have file references.
Signed-off-by: Jeff Ortel <jortel@redhat.com>
shawn-hurley
added a commit
that referenced
this pull request
Jul 3, 2024
This reverts commit 19a20e8.
dymurray
pushed a commit
that referenced
this pull request
Jul 3, 2024
This was referenced Jul 10, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default reaper frequency is (1) minute.
The reapers are performing 3-4 queries for every file and bucket evaluated for reaping. With the addition of attaching files to tasks and task-reports, the number of files has increased substantially. The current algorithm will run 3-4 queries for each resource evaluated.
For example: A deployment with 2000 analyzed applications can have ~25,000 files. To evaluate 4 resources for references (Task, TaskGroup, Rule, Target) resulted in 100,000 queries each reaper run.
This PR each run (default: 1/ minute) :