Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add application ref to analysis (list) resources. #714

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Jul 9, 2024

Add Analysis application ref to listed analysis resources.

- id: 1
  createUser: admin.noauth
  createTime: 2024-07-08T21:10:58.827832003-07:00
  application:
    id: 1
    name: Daytrader7
  effort: 25000
  commit: 42b22a90

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel jortel requested a review from mansam July 9, 2024 04:40
@@ -147,7 +147,7 @@ func (h AnalysisHandler) List(ctx *gin.Context) {
// Find
db := h.DB(ctx)
db = db.Model(&model.Analysis{})
db = db.Preload("Application")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hint: preload() does not work with cursors.

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jortel jortel merged commit e674440 into konveyor:main Jul 9, 2024
14 checks passed
@jmontleon
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants