Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Harmonize the render of task data between the task drawer and the task table #1969

Closed
sjd78 opened this issue Jun 20, 2024 · 2 comments
Closed

[BUG] Harmonize the render of task data between the task drawer and the task table #1969

sjd78 opened this issue Jun 20, 2024 · 2 comments
Assignees
@rszwajko
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.5.0

Comments

@sjd78
Copy link
Member

sjd78 commented Jun 20, 2024

Followup to: #1955, #1957

The task manager drawer and the task table both have code to render tasks. We should look at the code and extract common work to maintain visual content consistency across the UI.

This can include:

  • Status icons
  • Status icon tooltips
  • create, start, terminate date formats and intervals
@sjd78 sjd78 added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/normal Higher priority than priority/minor. Nice to have. labels Jun 20, 2024
This was referenced Jun 20, 2024
Merged
Merged
@sjd78 sjd78 added this to the v0.5.0 milestone Jun 20, 2024
@rszwajko rszwajko self-assigned this Jun 25, 2024
@rszwajko rszwajko mentioned this issue Jun 25, 2024
Merged
sjd78 pushed a commit that referenced this issue Jun 27, 2024
@rszwajko
🐛 Refactor task state to icon mapping (#1984)
00689bb 
Follow the mapping used by the drawer with following changes:
1. use PauseCircleIcon also for QuotaBlocked state
2. use TaskIcon for Ready state (instead of CheckCircleIcon)
3. use CheckCircleIcon for state Succeeded

Part-of: #1969

---------

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
@rszwajko rszwajko mentioned this issue Jul 3, 2024
Merged
@rszwajko
Copy link
Collaborator

rszwajko commented Jul 3, 2024

@sjd78
Created #1994 as part of this issue. The improvement here is to be better at displaying local time. The format will be still different then in the drawer because use cases are different - in the table we need an easy way to establish a sort order which makes ISO 8601 is a better choice. In the drawer we can keep the humanized/localized formats.

@rszwajko rszwajko mentioned this issue Jul 3, 2024
Open
@rszwajko
Copy link
Collaborator

rszwajko commented Jul 3, 2024

Moved the remaining part to a separate issue to be handled in the next release cycle.

@sjd78 sjd78 closed this as completed Jul 3, 2024
rszwajko added a commit that referenced this issue Jul 3, 2024
@rszwajko
🐛 Drop UTC offset for local time used in tasks table (#1994)
490a04b 
The API provides date/time in UTC. For user convenience we display it in
the browser time zone. Before this PR, UTC offset for the local time
zone was included.

The format used is a subset of ISO 8601 which allows for predictable
sorting in the table.
Format string: "YYYY-MM-DD HH:mm:ss".
Example date: "2024-07-03 13:21:44".

Part-of: #1969

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rszwajko rszwajko

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.5.0
Development

No branches or pull requests
2 participants
@sjd78 @rszwajko