Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Cancel task option enabled after cancel has completed #1993

Closed
1 task done
ibolton336 opened this issue Jul 2, 2024 · 1 comment · Fixed by #2023
Closed
1 task done

[BUG] Cancel task option enabled after cancel has completed #1993

ibolton336 opened this issue Jul 2, 2024 · 1 comment · Fixed by #2023
Assignees
@sjd78
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.5.0

Comments

@ibolton336
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

latest

Priority

Critical

Current Behavior

The "Cancel" option remains enabled in the kebab menu, allowing users to attempt cancellation again, which can lead to confusion and potential errors.

Expected Behavior

After the successful cancellation of an analysis, the "Cancel" option should be disabled or removed from the kebab menu for the affected application row.

How Reproducible

Always (Default)

Steps To Reproduce

Navigate to the application table view.
Start an analysis on any application.
Click on the kebab menu (three vertical dots) for the application row where the analysis is running.
Select the "Cancel" option to cancel the analysis.
Confirm the cancellation and wait for it to complete successfully.
Click on the kebab menu for the same application row again.

Environment

- OS:

Anything else?

No response
@ibolton336 ibolton336 added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 2, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Jul 2, 2024
@sjd78 sjd78 added this to the v0.5.0 milestone Jul 18, 2024
@sjd78 sjd78 added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/normal Higher priority than priority/minor. Nice to have. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jul 18, 2024
@dymurray dymurray modified the milestones: v0.5.0, v0.5.1 Jul 18, 2024
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Jul 23, 2024
@sjd78
🐛 Fix application table isTaskCancellable
e430ed5 
Application analysis tasks should be cancellable when
the task in NOT in a terminal state.  Use the
`TaskStates.Terminal` collection for the check so all
current terminal states are considered.

Resolves: konveyor#1993
Resolves: https://issues.redhat.com/browse/MTA-3219

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
@sjd78 sjd78 modified the milestones: v0.5.1, v0.5.0 Jul 23, 2024
@sjd78 sjd78 self-assigned this Jul 23, 2024
@sjd78 sjd78 mentioned this issue Jul 23, 2024
Merged
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Jul 23, 2024
@sjd78
🐛 Fix application table isTaskCancellable
88296b0 
Application analysis tasks should be cancellable when
the task in NOT in a terminal state.  Use the
`TaskStates.Terminal` collection for the check so all
current terminal states are considered.

Resolves: konveyor#1993
Resolves: https://issues.redhat.com/browse/MTA-3219

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
@sjd78 sjd78 closed this as completed in 727ee63 Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjd78 sjd78

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

🐛 Fix application table isTaskCancellable sjd78/tackle2-ui
3 participants
@sjd78 @ibolton336 @dymurray