Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Cannot edit an application that has a credential/identity assigned #2007

Closed
1 task done
sjd78 opened this issue Jul 11, 2024 · 2 comments · Fixed by #2008
Closed
1 task done

[BUG] Cannot edit an application that has a credential/identity assigned #2007

sjd78 opened this issue Jul 11, 2024 · 2 comments · Fixed by #2008
Assignees
@sjd78
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.5.0

Comments

@sjd78
Copy link
Member

sjd78 commented Jul 11, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.5-beta.1

Priority

Critical

Current Behavior

If an application has a source credentials or a maven settings assigned, the application cannot be edited.

The edit modal opens and changes can be made, but the Save action will fail with an error 400.

Expected Behavior

Save should complete successfully.

How Reproducible

Always (Default)

Steps To Reproduce

  1. Create an application
  2. Create a credential
  3. Manage the credentials for the application created in 1 and select the credential created in 2
  4. Edit the application
  5. Make a change anywhere and click 'Save'

Environment

Any

Anything else?

No response
@sjd78 sjd78 added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 11, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Jul 11, 2024
@sjd78 sjd78 self-assigned this Jul 11, 2024
@sjd78 sjd78 added priority/critical Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jul 11, 2024
@sjd78 sjd78 added this to the v0.5.0 milestone Jul 11, 2024
@sjd78
Copy link
Member Author

sjd78 commented Jul 11, 2024

This is a regression from #1985

sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Jul 11, 2024
@sjd78
🐛 Fix application edit data source
378b0f6 
Resolves: konveyor#2007

Summary of changes:
  - The application edit form needs to use the base
    `Application` data and not the `DecoratedApplication`
    as its basis for generating an update request.  Extra
    information added by the decoration will be unknown
    to the hub endpoint and will cause issues.

  - All references to `Application` in the application
    table code have been updated to `DecoratedApplication`

  - Any adjustments needed when a `DecoratedApplication` is
    passed to a child component as an `Application` have
    been made

  - The dereferencing part of decoration has been moved to
    a `direct` container.  This will allow the reuse of the
    `Application`` property name without replacing it.

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Jul 11, 2024
@sjd78
🐛 Fix application edit data source
ce80306 
Resolves: konveyor#2007

Summary of changes:
  - The application edit form needs to use the base
    `Application` data and not the `DecoratedApplication`
    as its basis for generating an update request.  Extra
    information added by the decoration will be unknown
    to the hub endpoint and will cause issues.

  - All references to `Application` in the application
    table code have been updated to `DecoratedApplication`

  - Any adjustments needed when a `DecoratedApplication` is
    passed to a child component as an `Application` have
    been made

  - The dereferencing part of decoration has been moved to
    a `direct` container.  This will allow the reuse of the
    `Application`` property name without replacing it.

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
@sjd78 sjd78 mentioned this issue Jul 11, 2024
Merged
@sjd78 sjd78 closed this as completed in 8ddf4f1 Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjd78 sjd78

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

🐛 Fix application edit data source sjd78/tackle2-ui
1 participant
@sjd78