🌱 Refactor WithUiId handling to use hook useWithUiId()
#1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1555 +/- ##
==========================================
+ Coverage 39.18% 39.20% +0.01%
==========================================
Files 146 146
Lines 4856 4857 +1
Branches 1164 1164
==========================================
+ Hits 1903 1904 +1
Misses 2939 2939
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sjd78
force-pushed
the
refactor_withuiid
branch
3 times, most recently
from
d2d5b1f
to
13ff1f8
Compare
ibolton336
reviewed
Nov 28, 2023
ibolton336
requested changes
Nov 28, 2023
ibolton336
requested changes
Nov 28, 2023
ibolton336
reviewed
Nov 28, 2023
ibolton336
reviewed
Nov 28, 2023
ibolton336
reviewed
Nov 28, 2023
ibolton336
reviewed
Nov 28, 2023
ibolton336
reviewed
Nov 28, 2023
sjd78
force-pushed
the
refactor_withuiid
branch
from
c954d88
to
ad52fbf
Compare
sjd78
force-pushed
the
refactor_withuiid
branch
from
ad52fbf
to
69016e7
Compare
Following up on konveyor#1554, create hook `useWithUiId()` to handle injecting UI id to objects. Any object `T` going will to the hook will come out as a `WithUiId<T>` object. Tables using the UI id have been adjusted to use the Constant `UI_UNIQUE_ID` as the `WithUiId<T>` table data `idProperty`. All uses of `WithUiId<T>` are now handled the same way. Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
- Doc language
- Remove custom query hook return type interfaces in favor of
using TS type inference
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
force-pushed
the
refactor_withuiid
branch
from
69016e7
to
92d4864
Compare
ibolton336
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #1554, create hook
useWithUiId()to handle injecting UI id to objects. Any objectTgoing will to the hook will come out as aWithUiId<T>object.Tables using the UI id have been adjusted to use the Constant
UI_UNIQUE_IDas theWithUiId<T>table dataidProperty.All uses of
WithUiId<T>are now handled the same way.