✨ Move Analysis Details to full page view #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Analysis details in page (for a valid task)
Invalid task and application
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1930 +/- ##
==========================================
+ Coverage 39.20% 42.10% +2.90%
==========================================
Files 146 163 +17
Lines 4857 5239 +382
Branches 1164 1276 +112
==========================================
+ Hits 1904 2206 +302
- Misses 2939 3017 +78
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sjd78
approved these changes
Jun 7, 2024
client/src/app/pages/applications/applications-table/applications-table.tsx
Outdated
Show resolved
Hide resolved
Related changes: 1. extend BreadCrumbPath component to support non-links 2. refactor CSS styles for SimpleDocumentViewer to support both modal and in-page mode 3. create new route for the analysis details page: /applications/:applicationId/analysis-details/:taskId Reference-Url: konveyor#1929 Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
ibolton336
approved these changes
Jun 7, 2024
This was referenced Jun 22, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related changes:
and in-page mode
/applications/:applicationId/analysis-details/:taskId
Part-of: #1929