🐛 Provide unique keys for components in MultiselectFilterControl #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The component creates ToolbarFilter and ChipGroup components from provided data which may be dynamic. It may happen that the created components have the same keys as other filters created manually. Provided unique keys are built by concatenating category title and group name. The category title is known at compile time and is expected to be unique. Group name is calculated from the provided data. Each group results in new ToolbarFilter/ChipGroup Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1949 +/- ##
==========================================
+ Coverage 39.20% 42.16% +2.96%
==========================================
Files 146 166 +20
Lines 4857 5320 +463
Branches 1164 1330 +166
==========================================
+ Hits 1904 2243 +339
- Misses 2939 3061 +122
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1 task
ibolton336
approved these changes
Jun 10, 2024
This was referenced Jun 22, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1944 introduced by #1903 (follow-up to #1946)
The MultiselectFilterControl component discovers groups from provided data. Each group results in a new ToolbarFilter/ChipGroup pair. Before this fix, the keys were based only on group names. In case of Language filter it created a collision with Language group derived from Tags.
After this fix, the keys are built by concatenating category title and group name. The category title is known at compile time and is expected to be unique among all filters on the screen.
Reference-Url: #1944
Reference-Url: #1903
Reference-Url: #1946