Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Allow creating archetype without tags #2047

Merged
merged 2 commits into from
Aug 5, 2024
Merged

🐛 Allow creating archetype without tags #2047

merged 2 commits into from
Aug 5, 2024

Conversation

rszwajko
Copy link
Collaborator

@rszwajko rszwajko commented Aug 2, 2024

Resolves: #1999

@rszwajko
Allow creating archetype without tags
c13311f 
Resolves: konveyor#1999
Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
@rszwajko
Copy link
Collaborator Author

rszwajko commented Aug 2, 2024

After the fix

Screenshot from 2024-08-02 17-33-51

@codecov Codecov
Copy link

codecov bot commented Aug 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.37%. Comparing base (b654645) to head (7ebe154).
Report is 209 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2047      +/-   ##
==========================================
+ Coverage   39.20%   42.37%   +3.17%     
==========================================
  Files         146      172      +26     
  Lines        4857     5520     +663     
  Branches     1164     1376     +212     
==========================================
+ Hits         1904     2339     +435     
- Misses       2939     3065     +126     
- Partials       14      116     +102
Flag Coverage Δ
client 42.37% <ø> (+3.17%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjd78 sjd78 added this to the v0.5.1 milestone Aug 5, 2024
@sjd78 sjd78 added the cherry-pick/release-0.5 This PR should be cherry-picked to release-0.4 branch. label Aug 5, 2024
sjd78
sjd78 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjd78 sjd78 merged commit 984543d into konveyor:main Aug 5, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 5, 2024
@rszwajko @web-flow
🐛 Allow creating archetype without tags (#2047)
bd4e347 
Resolves: #1999

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
@sjd78 sjd78 mentioned this pull request Aug 5, 2024
Merged
sjd78 pushed a commit that referenced this pull request Aug 5, 2024
@konveyor-ci-bot
🐛 [backport release-0.5] Allow creating archetype without tags (#2047) (
dbbc801 
#2050)

Resolves: #1999
Backport-of: #2047

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 sjd78 approved these changes

@ibolton336 ibolton336 Awaiting requested review from ibolton336 ibolton336 is a code owner

Assignees
No one assigned
Labels
cherry-pick/release-0.5 This PR should be cherry-picked to release-0.4 branch.
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging this pull request may close these issues.

[BUG] Archetype tags should be optional
2 participants
@rszwajko @sjd78