Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ addition edit icon out of ActionColumns #2098

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Shevijacobson
Copy link

Changes Made:

  • Removed the edit action from the ActionsColumn.

  • Added a dedicated edit icon outside the ActionsColumn, providing a clearer and more focused user interface.

@Shevijacobson Shevijacobson force-pushed the m_s_ar-table branch 3 times, most recently from a0d63b6 to b14dceb Compare September 18, 2024 08:19
Signed-off-by: Shevijacobson <shevijacob@gmail.com>
Copy link
Collaborator

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.01%. Comparing base (b654645) to head (5b2c945).
Report is 236 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2098      +/-   ##
==========================================
+ Coverage   39.20%   42.01%   +2.81%     
==========================================
  Files         146      175      +29     
  Lines        4857     5617     +760     
  Branches     1164     1392     +228     
==========================================
+ Hits         1904     2360     +456     
- Misses       2939     3136     +197     
- Partials       14      121     +107     
Flag Coverage Δ
client 42.01% <ø> (+2.81%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shevijacobson <shevijacob@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants