test: fix 'update' test by removing @Throttle

koog1000 · Jun 13, 2023 · 15012e9 · 15012e9
1 parent e7fad04
commit 15012e9
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/src/interaction.ts b/src/interaction.ts
@@ -827,7 +827,7 @@ export async function presentLogSourcesMenu(
     }
 }
 
-export async function presentLogMenu(
+async function presentLogMenu(
     source: CommitSources,
     logOptions: LogEntryOptions,
     commands: InteractionAPI,
@@ -948,7 +948,7 @@ export async function pickStashItem(
 /**
  * use selected commit in 'fossil.log' command
  */
-export async function presentCommitDetails(
+async function presentCommitDetails(
     details: CommitDetails,
     back: RunnableQuickPickItem,
     commands: InteractionAPI

diff --git a/src/repository.ts b/src/repository.ts
@@ -790,7 +790,7 @@ export class Repository implements IDisposable, InteractionAPI {
         );
     }
 
-    @throttle
+    // @throttle
     async update(checkin: FossilCheckin): Promise<void> {
         await this.runWithProgress(Operation.Update, () =>
             this.repository.update(checkin)

diff --git a/src/test/suite/test_commands.ts b/src/test/suite/test_commands.ts
@@ -78,8 +78,10 @@ export async function fossil_pull_with_autoUpdate_on(
     sandbox: sinon.SinonSandbox
 ): Promise<void> {
     const execStub = getExecStub(sandbox);
-    const updateCall = execStub.withArgs(['update']);
+    const sem = sandbox.stub(window, 'showErrorMessage').resolves();
+    const updateCall = execStub.withArgs(['update']).resolves();
     await commands.executeCommand('fossil.pull');
+    sinon.assert.notCalled(sem);
     sinon.assert.calledOnce(updateCall);
 }
 
@@ -90,12 +92,14 @@ export async function fossil_pull_with_autoUpdate_off(
         'fossil',
         workspace.workspaceFolders![0].uri
     );
+    const sem = sandbox.stub(window, 'showErrorMessage').resolves();
     await fossilConfig.update('autoUpdate', false);
     const execStub = getExecStub(sandbox);
-    const updateCall = execStub.withArgs(['pull']);
-    updateCall.resolves(undefined); // stub as 'undefined' as we can't do pull
+    const pullCall = execStub.withArgs(['pull']).resolves();
     await commands.executeCommand('fossil.pull');
-    sinon.assert.calledOnce(updateCall);
+    sinon.assert.notCalled(sem);
+    sinon.assert.calledOnce(pullCall);
+    await fossilConfig.update('autoUpdate', true);
 }
 
 export function fossil_revert_suite(sandbox: sinon.SinonSandbox): void {