refactor: fix typing issue found by eslint

koog1000 · Aug 4, 2024 · a249dcf · a249dcf
1 parent d782cda
commit a249dcf
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/src/openedRepository.ts b/src/openedRepository.ts
@@ -44,8 +44,7 @@ export type FossilRemoteName = Distinct<string, 'Fossil Remote Name'>;
 /** https://fossil-scm.org/home/doc/trunk/www/checkin_names.wiki */
 export type FossilBranch = Distinct<string, 'Fossil Branch Name'>;
 /** https://fossil-scm.org/home/doc/trunk/www/checkin_names.wiki#special */
-const FossilSpecialTagsList = ['current', 'parent', 'tip'] as const;
-export type FossilSpecialTags = (typeof FossilSpecialTagsList)[number];
+export type FossilSpecialTags = 'current' | 'parent' | 'tip';
 export type FossilTag = Distinct<string, 'Fossil Tag Name'> | 'closed';
 export type FossilHash = Distinct<string, 'Fossil SHA Hash'>;
 export type FossilCheckin =

diff --git a/src/test/suite/commandSuites.ts b/src/test/suite/commandSuites.ts
@@ -323,7 +323,6 @@ export function CleanSuite(this: Suite): void {
             { modal: true },
             '&&Delete Files'
         );
-        sinon.assert.calledOnceWithExactly;
         sinon.assert.calledOnceWithMatch(cleanCallStub, [
             'clean',
             ...repository.untrackedGroup.resourceStates.map(
@@ -362,7 +361,6 @@ export function CleanSuite(this: Suite): void {
             { modal: true },
             '&&Delete Files'
         );
-        sinon.assert.calledOnceWithExactly;
         sinon.assert.calledOnceWithMatch(cleanCallStub, [
             'clean',
             ...repository.untrackedGroup.resourceStates.map(

diff --git a/src/test/suite/qualityOfLifeSuite.ts b/src/test/suite/qualityOfLifeSuite.ts
@@ -3,11 +3,11 @@ import { commands, window, workspace, Uri } from 'vscode';
 import * as assert from 'assert/strict';
 import * as fs from 'fs/promises';
 import * as vscode from 'vscode';
-import { languages } from 'vscode';
+import type { languages } from 'vscode';
 import * as sinon from 'sinon';
 import { add, getRepository } from './common';
-import { OpenedRepository } from '../../openedRepository';
-import { LineChange } from '../../revert';
+import type { OpenedRepository } from '../../openedRepository';
+import type { LineChange } from '../../revert';
 import { delay } from '../../util';
 
 function PraiseSuite(this: Suite) {

diff --git a/src/test/summaryAsMarkdown.ts b/src/test/summaryAsMarkdown.ts
@@ -130,5 +130,6 @@ async function main(
 main(...process.argv.slice(2))
     .then(code => process.exit(code))
     .catch(reason => {
-        console.log(reason), process.exit(1);
+        console.log(reason);
+        process.exit(1);
     });